Crafting can be great when it is treated as a first-class citizen in terms of gameplay and player agency.
Of course, the only franchise I can think of that does this well is Atelier.
It's pretty damn sad how many people here seem to hate it.
The best ever will always be Star Wars: Galaxies. Man it was great. You could literally just be a crafter. My brother was an architect. He had a shop in a town he literally built himself and ran, as well as a huge house he had built. He paid me to rent all my miner slots and he had a huge mining operation going on for resources. I did a little bit of everything. I was a commando (roasting fools with a flamethrower) a fencer, a droid engineer, a musician, a carbiner. It was an amazing social game. You could hang out all day in the cantina and it was legit like hanging out in a cantina. You chat with your buddies and watch/tip the entertainers. I miss the game dearly. Even the CU didn't bother me that much but it came a completely different game after the NGE. I stopped playing when the NGE hit. I remember there would be a huddle of like 50 people around the droid at the spaceport waiting for the shuttle. The space expac was cool too, imo, if not a little too easy. It took interior designing your own home to space! The space yacht was awesome.
Some other great games that I think are worth mention are Vagrant Story. Before Atelier, there was this game. Crafting is almost required in order to stay ahead of the enemy difficulty curve, but whether or not each new weapon is an improvement is, at best, a tough call. Experimentation is necessary, but also extremely costly (since the two source weapons/parts are destroyed in the process of creating a new one). Until you gain the teleportation ability, the material limitations of each workshop make it impractical to perform the multiple-iteration combinations required to make truly effective equipment. It made crafting worthwhile and really made me want to experiment.
I'm actually enjoying the crafting system in Elder Scrolls Online. It's not close to SWG but then again, what is? It's simple enough but it has more depth than WoW does but not so much that I have to dedicated too much time to it. These days, that's best for me.