It's not a shit deal at all. What if you wanted to try Madden, FIFA, and Battlefield but didn't want to buy them full price? What if you go digital-only and the 10% is actually pretty good for you?It's just a shit deal, period. $30 a year to buy into their ecosystem for the sake of a bunch of games that've finished selling through and whose sole purpose is to act as DLC platforms, including a year-old long-broken shooter, a couple of outdated sports games, and... Peggle.
10% off on EA digital purchases? By golly, that means that after purchasing 5 EA games at full price in a single year, I'm practically STEALING money from them! I might just do it all via DLC!
The shame of it is that EA actually has a spectacular catalog of games through its long history of development and acquisitions. But, bringing those games over and making the "Vault" be anything more than a sham seems beyond them.
Just because it's a shit deal for you doesn't make it a shit deal for everyone. But, like I said, buy it for the now.