I don't tend to murder my controllers, so they've all lasted me for as long as I've bought them.
The only exceptions:
- A couple of N64 controllers due to lots of Mario Party. Those analog sticks ain't great.
-Two of my main Gamecube controllers that I used in Melee/Brawl tournaments. Probably lasted me 1000+ hours each of Melee and Brawl gameplay, among other Gamecube games. If you've ever played Melee competitively, you know you are pressing a TON of buttons. Eventually my analog stick crapped out on one of them, and the L button on another.